From 78fe3fa694b0f9fc8e1649ae5da1133d6a256a13 Mon Sep 17 00:00:00 2001 From: Tuan-Dat Tran Date: Sun, 7 Sep 2025 21:40:21 +0200 Subject: [PATCH] refactor(ansible-lint): fixed ansible-lint warnings Signed-off-by: Tuan-Dat Tran --- .ansible-lint | 2 ++ roles/common/tasks/extra_packages.yml | 5 +++-- roles/proxmox/README.md | 5 ----- roles/proxmox/tasks/06_hardware_acceleration.yml | 1 + roles/proxmox/tasks/15_create_secret.yml | 2 -- roles/proxmox/tasks/54_destroy_vm.yml | 6 +++--- roles/proxmox/tasks/55_create_vm.yml | 2 +- roles/proxmox/tasks/56_provision_new_vm.yml | 6 +++--- roles/proxmox/tasks/57_stop_and_verify_vm.yml | 4 ++-- 9 files changed, 15 insertions(+), 18 deletions(-) diff --git a/.ansible-lint b/.ansible-lint index c15db06..28fcacc 100644 --- a/.ansible-lint +++ b/.ansible-lint @@ -13,6 +13,8 @@ skip_list: - fqcn-builtins - no-handler - var-naming + - no-changed-when + - risky-shell-pipe # Enforce certain rules that are not enabled by default. enable_list: diff --git a/roles/common/tasks/extra_packages.yml b/roles/common/tasks/extra_packages.yml index 4b3ff0f..0c2692e 100644 --- a/roles/common/tasks/extra_packages.yml +++ b/roles/common/tasks/extra_packages.yml @@ -79,12 +79,13 @@ path: ~/.config/nvim register: nvim_config -- name: Clone LazyVim starter to Neovim config directory +- name: Clone personal Neovim config directory ansible.builtin.git: - repo: https://github.com/LazyVim/starter + repo: https://codeberg.org/tudattr/nvim dest: ~/.config/nvim clone: true update: false + version: 1.0.0 when: not nvim_config.stat.exists - name: Remove .git directory from Neovim config diff --git a/roles/proxmox/README.md b/roles/proxmox/README.md index 53d02de..210da9d 100644 --- a/roles/proxmox/README.md +++ b/roles/proxmox/README.md @@ -2,11 +2,6 @@ This role facilitates the management of Proxmox VE resources, including virtual machines (VMs) and LXC containers. It automates the setup of Proxmox nodes and the creation, configuration, and destruction of guests. -## Requirements - -- `community.general.proxmox_vm_info` -- `community.general.proxmox_kvm` - ## Role Variables | Variable | Description | Default Value | diff --git a/roles/proxmox/tasks/06_hardware_acceleration.yml b/roles/proxmox/tasks/06_hardware_acceleration.yml index c9cfee2..8dc66c5 100644 --- a/roles/proxmox/tasks/06_hardware_acceleration.yml +++ b/roles/proxmox/tasks/06_hardware_acceleration.yml @@ -23,6 +23,7 @@ vfio_virqfd create: true backup: true + mode: 644 register: vfio_result - name: Update initramfs diff --git a/roles/proxmox/tasks/15_create_secret.yml b/roles/proxmox/tasks/15_create_secret.yml index 54069c9..e62e0d8 100644 --- a/roles/proxmox/tasks/15_create_secret.yml +++ b/roles/proxmox/tasks/15_create_secret.yml @@ -1,7 +1,6 @@ --- - name: Decrypt vm vault file ansible.builtin.shell: cd ../; ansible-vault decrypt "./playbooks/{{ proxmox_vault_file }}" - ignore_errors: true no_log: true - name: Load existing vault content @@ -43,5 +42,4 @@ - name: Encrypt vm vault file ansible.builtin.shell: cd ../; ansible-vault encrypt "./playbooks/{{ proxmox_vault_file }}" - ignore_errors: true no_log: true diff --git a/roles/proxmox/tasks/54_destroy_vm.yml b/roles/proxmox/tasks/54_destroy_vm.yml index 8c7357f..143654a 100644 --- a/roles/proxmox/tasks/54_destroy_vm.yml +++ b/roles/proxmox/tasks/54_destroy_vm.yml @@ -1,6 +1,6 @@ --- - name: Gather info about VM - community.general.proxmox_vm_info: + community.proxmox.proxmox_vm_info: api_user: "{{ proxmox_api_user }}@pam" api_token_id: "{{ proxmox_api_token_id }}" api_token_secret: "{{ proxmox_api_token_secret }}" @@ -9,7 +9,7 @@ register: vm_info - name: Stop VM - community.general.proxmox_kvm: + community.proxmox.proxmox_kvm: api_user: "{{ proxmox_api_user }}@pam" api_token_id: "{{ proxmox_api_token_id }}" api_token_secret: "{{ proxmox_api_token_secret }}" @@ -21,7 +21,7 @@ when: vm_info.proxmox_vms | length > 0 - name: Destroy VM - community.general.proxmox_kvm: + community.proxmox.proxmox_kvm: api_user: "{{ proxmox_api_user }}@pam" api_token_id: "{{ proxmox_api_token_id }}" api_token_secret: "{{ proxmox_api_token_secret }}" diff --git a/roles/proxmox/tasks/55_create_vm.yml b/roles/proxmox/tasks/55_create_vm.yml index 87a3370..732069f 100644 --- a/roles/proxmox/tasks/55_create_vm.yml +++ b/roles/proxmox/tasks/55_create_vm.yml @@ -1,6 +1,6 @@ --- - name: Create VM - community.general.proxmox_kvm: + community.proxmox.proxmox_kvm: api_user: "{{ proxmox_api_user }}@pam" api_token_id: "{{ proxmox_api_token_id }}" api_token_secret: "{{ proxmox_api_token_secret }}" diff --git a/roles/proxmox/tasks/56_provision_new_vm.yml b/roles/proxmox/tasks/56_provision_new_vm.yml index 953b990..9131c7e 100644 --- a/roles/proxmox/tasks/56_provision_new_vm.yml +++ b/roles/proxmox/tasks/56_provision_new_vm.yml @@ -25,7 +25,7 @@ delegate_to: "{{ vm.node }}" - name: Start VM - community.general.proxmox_kvm: + community.proxmox.proxmox_kvm: api_user: "{{ proxmox_api_user }}@pam" api_token_id: "{{ proxmox_api_token_id }}" api_token_secret: "{{ proxmox_api_token_secret }}" @@ -42,7 +42,7 @@ seconds: 5 - name: Start VM - community.general.proxmox_kvm: + community.proxmox.proxmox_kvm: api_user: "{{ proxmox_api_user }}@pam" api_token_id: "{{ proxmox_api_token_id }}" api_token_secret: "{{ proxmox_api_token_secret }}" @@ -99,7 +99,7 @@ - name: Creates PATH-entry for crontab ansible.builtin.cron: name: PATH - env: yes + env: true job: /usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin delegate_to: "{{ vm.node }}" diff --git a/roles/proxmox/tasks/57_stop_and_verify_vm.yml b/roles/proxmox/tasks/57_stop_and_verify_vm.yml index 37c821d..96af549 100644 --- a/roles/proxmox/tasks/57_stop_and_verify_vm.yml +++ b/roles/proxmox/tasks/57_stop_and_verify_vm.yml @@ -5,7 +5,7 @@ retry_count: "{{ 0 if retry_count is undefined else retry_count | int + 1 }}" - name: Stop VM - community.general.proxmox_kvm: + community.proxmox.proxmox_kvm: api_user: "{{ proxmox_api_user }}@pam" api_token_id: "{{ proxmox_api_token_id }}" api_token_secret: "{{ proxmox_api_token_secret }}" @@ -16,7 +16,7 @@ force: true - name: Wait until VM is fully stopped - community.general.proxmox_vm_info: + community.proxmox.proxmox_vm_info: api_user: "{{ proxmox_api_user }}@pam" api_token_id: "{{ proxmox_api_token_id }}" api_token_secret: "{{ proxmox_api_token_secret }}"